Update AToMiC demo page to support dense search #1721
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasper-xian @justram would appreciate a review here! |
|
Not sure I'm the right person to comment on this, but the way we did pre-encoded image queries was something like this: Topics: {'id': , 'title': } So you could use the image-id to search for the right image. I'm not sure what this mapping stuff relates to in general though, but I think the app looks good! @justram can probably comment more about it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update AToMiC demo page to support the dense searchers.
One issue is that it is difficult to navigate the image ids when searching for pre-encoded queries for images. I was thinking of adding a index->topic file mapping in the server, and in
search_options()we search the topic file to get the image_urls of the matching options to pass to the client side. Did you have any other suggestions on how to better handle this @jasper-xian ?Demo video: https://youtu.be/ukb4Bc0XzW4